Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more automation #2961

Closed
axic opened this issue Sep 9, 2020 · 5 comments
Closed

Introduce more automation #2961

axic opened this issue Sep 9, 2020 · 5 comments

Comments

@axic
Copy link
Member

axic commented Sep 9, 2020

We have the following pieces of automation currently:

  1. automerger bot
  2. syntax tests
    a. eipv (preplaced the old validator not long ago](Switch validator to eipv #2860))
    b. spellcheck
    c. hmlcheck
  3. greeter bot
  4. stale bot (added lately)

The automerger can automatically merge PRs, except those changing statuses or adding new files. It is a Python-based code run on Google AppEngine and triggered by Travis.

The syntax tests are executed via Travis and are displayed on github with a red or green "continuous integration" icons. This is sometimes overlooked by authors. The automerger will also not act, if the status is red.

The most important check we have is the eipv one: it validates a lot of formatting requirements, but not every single requirement. For outstanding issues check here.

The greeter bot reminds new contributors to read EIP-1, while the stale bot ensures that old issues are closed if there is no activity.


Now, this looks great, but it could be better. In order to speed up the review process we should make sure that eipv checks for a lot more mistakes. The most common mistake is not having all the appropriate sections: the correct names, ordering, indentation, or having non-standard sections.

The second biggest problem is that a lot of contributors are not familiar with travis and/or continuous integration. We should introduce a bot (eipv-bot) which creates comments for each mistake. Then mostly editors would be restricted to assigning EIP numbers.

Once #2941 is properly decided on we could introduce another bot to mark long untouched drafts as status=Withdrawn reason="withdrawn due to inactivity". It should create a PR, and ideally merge it after some period of inactivity, or let editors merge it.


I think we should move over to Github Actions, because:

  • We can define all the rules of execution in this repository in the .github/workflows directory
  • Can place all the bots in a separate repository

I propose the following projects to undertake:

  1. eipv-bot: github action compatible bot which executes eipv and creates comments for each issue
  2. abandon-bot: github action compatible bot which creates a PR marking old drafts as withdrawn
  3. automerger-bot: github action compatible bot which replaces the automerger
@MicahZoltu
Copy link
Contributor

I'm not opposed to any of the suggested changes. Note: I am currently too busy to apply any of them.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the stale label Nov 2, 2021
@axic
Copy link
Member Author

axic commented Nov 2, 2021

Huh, should review what's left from the above.

@axic axic removed the stale label Nov 2, 2021
@Pandapip1
Copy link
Member

Might be superseded by ethereum/EIP-Bot#55

@MicahZoltu
Copy link
Contributor

I believe most of these are now issues in the EIP-Bot repository. Closing this for now, and I encourage everyone to add new suggestions for the bot as issues over at that repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants