-
Notifications
You must be signed in to change notification settings - Fork 37
EIP Bot should error if a file contains an SPDX identifier other than CC0 #96
Comments
Please could you check PR 87. I think that resolves this issue either. |
Addressed by EIPW now. |
It isn't (see ethereum/eipw#11), and only checking the EIP itself is on the roadmap. I don't have any plans to scan Solidity files (or |
Uh, why not? It goes way better in the validator than it does here. |
I feel like scanning projects for licenses is incredibly hard, and I'd rather not create a lint that gives an over-exaggerated sense of safety. |
I can write those lints if you want. I'd have to learn rust first, but it can't be too hard... right? |
Rust is fun! Totally open to a PR, but keep my concern in mind. |
Did one better: ethereum/EIPs#5379. Now you can continue to only care about EIPs and let other actions do the other work :) |
Re-opening this until this gets implemented somewhere, or an issue to track the problem is created somewhere. |
Tracked in ethereum/EIPs#5379 |
This would help avoid things like https://github.com/ethereum/EIPs/blob/master/assets/eip-4400/contracts/ERC721Consumable.sol having the wrong license.
The text was updated successfully, but these errors were encountered: