Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

EIP Bot should error if a file contains an SPDX identifier other than CC0 #96

Closed
Pandapip1 opened this issue Jul 11, 2022 · 11 comments
Closed

Comments

@Pandapip1
Copy link
Member

This would help avoid things like https://github.com/ethereum/EIPs/blob/master/assets/eip-4400/contracts/ERC721Consumable.sol having the wrong license.

@JEAlfonsoP
Copy link
Contributor

Please could you check PR 87. I think that resolves this issue either.

@MicahZoltu
Copy link
Contributor

#87

@MicahZoltu
Copy link
Contributor

Addressed by EIPW now.

@SamWilsn
Copy link

SamWilsn commented Jul 30, 2022

It isn't (see ethereum/eipw#11), and only checking the EIP itself is on the roadmap. I don't have any plans to scan Solidity files (or package.json, or any other package manager's files.)

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jul 30, 2022

I don't have any plans to scan Solidity files (or package.json, or anything other package manager's files.)

Uh, why not? It goes way better in the validator than it does here.

@SamWilsn
Copy link

Uh, why not?

I feel like scanning projects for licenses is incredibly hard, and I'd rather not create a lint that gives an over-exaggerated sense of safety.

@Pandapip1
Copy link
Member Author

I can write those lints if you want. I'd have to learn rust first, but it can't be too hard... right?

@SamWilsn
Copy link

Rust is fun! Totally open to a PR, but keep my concern in mind.

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jul 31, 2022

Did one better: ethereum/EIPs#5379. Now you can continue to only care about EIPs and let other actions do the other work :)

@MicahZoltu MicahZoltu reopened this Jul 31, 2022
@MicahZoltu
Copy link
Contributor

Re-opening this until this gets implemented somewhere, or an issue to track the problem is created somewhere.

@Pandapip1
Copy link
Member Author

Tracked in ethereum/EIPs#5379

@Pandapip1 Pandapip1 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants