Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Clarify 'NotActivated' Error Message for EVM Compatibility Issues #244

Open
ismailmoazami opened this issue Nov 2, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation prioritized

Comments

@ismailmoazami
Copy link

ismailmoazami commented Nov 2, 2024

Problem:
When executing a script with Foundry against Supersim, the following error was encountered:
EvmError: NotActivated

This error is ambiguous and does not provide clear guidance on its cause or resolution.

Solution:
The issue was resolved by specifying the EVM version as 'cancun' in the foundry.toml configuration file:

evm_version = "cancun"

Recommendation: To enhance developer experience and facilitate troubleshooting, it is recommended to update the error handling mechanism to provide more descriptive messages. For instance, replacing "NotActivated" with a message like "EVM version incompatibility detected. Consider setting evm_version = 'cancun' in your configuration." would offer clearer guidance to users.

@jakim929 jakim929 added the documentation Improvements or additions to documentation label Nov 4, 2024
@jakim929 jakim929 self-assigned this Nov 4, 2024
@jakim929
Copy link
Contributor

jakim929 commented Nov 4, 2024

thank you for the report - this is good feedback will incorporate into docs.

Longer term def agree that handling with better error returned from op-simulator is better, but right now I think we want to keep op-simulator as minimal as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation prioritized
Projects
None yet
Development

No branches or pull requests

2 participants