Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Templating via L2ChainIds #422

Open
blmalone opened this issue Dec 18, 2024 · 1 comment
Open

Generic Templating via L2ChainIds #422

blmalone opened this issue Dec 18, 2024 · 1 comment
Assignees

Comments

@blmalone
Copy link
Contributor

As discussed on a call with @mds1, @ElliotFriedman, @prateek105, @Ethnical and @blmalone.

We stepped through this forked feature: solidity-labs-io#10

To summarize, in the build function of newly created tasks, we should loop through L2 chain Ids that are imported from a task config .toml file. This way, a task can be reused for many or one chains without having to update any Solidity files. Only the .toml config files would need to be modified.

Similarly, the task may require specific values used in the upgrade e.g. 100_000 for a gas limit update. It's worth thinking about how these can also be parameterized into config instead of having them live in the Solidity file for the same reason as previously mentioned.

@ElliotFriedman
Copy link
Contributor

I'm tackling a lot of the safety scaffolding around the multisig state diff pre and post proposal. Once that is across the line I'm going to investigate this.

@blmalone blmalone assigned blmalone and ElliotFriedman and unassigned blmalone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants