Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing does not work on a ledger wallet #392

Open
Inphi opened this issue Dec 6, 2024 · 5 comments
Open

Signing does not work on a ledger wallet #392

Inphi opened this issue Dec 6, 2024 · 5 comments
Assignees

Comments

@Inphi
Copy link
Contributor

Inphi commented Dec 6, 2024

Bug Description

I'm on unable to sign a nested safe transaction for task execution(e.g. this).

❯ just --dotenv-path $(pwd)/.env  --justfile ../../../nested.just sign council

Running script with assertions
Using script /Users/inphi/optimism/superchain-ops/tasks/sep/021-stage-1-4/NestedSignFromJson.s.sol
Using council safe at 0xf64bc17485f0B4Ea5F06A96514182FC4cB561977
getting signer address...
Error:
Could not connect to Ledger device.
Make sure it's connected and unlocked, with no other desktop wallet apps open.

Context:
- received an unexpected empty response
Signing with:

[⠊] Compiling...
No files changed, compilation skipped
2024/12/05 19:10:27 Warning: signer creation failed: error deriving ledger account (have you unlocked?): reply lacks public key entry
Running 'forge script /Users/inphi/optimism/superchain-ops/tasks/sep/021-stage-1-4/NestedSignFromJson.s.sol --rpc-url https://ethereum-sepolia.publicnode.com --sig signJson(string,address) /Users/inphi/optimism/superchain-ops/tasks/sep/021-stage-1-4/input.json 0xf64bc17485f0B4Ea5F06A96514182FC4cB561977
No files changed, compilation skipped

This seems to be a more general bug in both eip712sign and cast on macos:

❯ eip712sign --address --hd-paths "m/44'/60'/0'/0/0" --ledger            12s 09:33:31
2024/12/06 09:33:32 Warning: signer creation failed: error deriving ledger account (have you unlocked?): reply lacks public key entry

❯ cast wallet address --ledger --mnemonic-derivation-path "m/44'/60'/0'/0/0"
Error:
Could not connect to Ledger device.
Make sure it's connected and unlocked, with no other desktop wallet apps open.

Context:
- received an unexpected empty response

Debugging

A recent change in behavior that I've noticed is that I'm required to launch the "Ethereum" app on my ledger wallet in order to interact with the ethereum account it using various CLI tools. This is a requirement to use the ledger-live CLI and also cast. Reading the Ethereum address works fine using cast, using the same above command, once I launch the Ethereum app. However, eip712sign fails with the same above error. I recently updated my Nano S Plus firmware to 1.3.0 in an attempt to fix the issue, but I'm unsure if this requirement is due to the firmware update.

Environment Information:

  • Operating System: MacOS Sonoma 14.7.1 - Apple Silicon
  • Foundry Versions Used: 143abd6a, e5dbb7a3, and 626221f5.
  • Device: Ledger Nano S Plus
@geoknee
Copy link
Contributor

geoknee commented Dec 9, 2024

Could this be related to ops fail on ARM machines due to eip712signer incompatibility ?

@Inphi
Copy link
Contributor Author

Inphi commented Dec 10, 2024

Could this be related to ops fail on ARM machines due to eip712signer incompatibility ?

I don't think so. The eip712signer works "fine" in the sense that it runs but is unable to recognize the ledger device. Whereas, I think the problem in that issue is that eip712signer would get killed by the OS because its binary target isn't expected.

@mds1
Copy link
Contributor

mds1 commented Dec 10, 2024

@Inphi This is with a ledger nano s?

@Inphi
Copy link
Contributor Author

Inphi commented Dec 10, 2024

@mds1 It's a Ledger Nano S Plus.

@blmalone blmalone self-assigned this Dec 10, 2024
@Ethnical
Copy link
Contributor

Okay, I am currently with @Inphi and we tried multiples hardware things as restart, change with a low level terminal (terminal native of macos) also changing usb and usbc port.

I also add the same issue with @sebastianst this morning but I was thinking was related to only the Flex.
#395
still investigating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants