-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just simulate/sign
prints an invalid tenderly simulation URL
#299
Comments
Some observations:
|
just simulate/sign
prints an invalid tenderly simulation URL
Using git bisect, I have confirmed foundry-rs/foundry#8543 is the PR that introduced this bug. Before that PR, URLs are properly encoded when logged: After, you can see the improper URL encoding: For reference, here is where the URL encoding and logging happens: https://github.com/base-org/contracts/blob/1db896f62d5189426efd3dbe28e908fda4a92ebf/script/universal/Simulator.sol#L129-L189 Opened foundry-rs/foundry#8700 to track |
Bug Description
In some user's environments but not others, the
just sign
andjust simulate
scripts are outputting tenderly simulation URLs with invalid URL escaping.Steps to Reproduce
The text was updated successfully, but these errors were encountered: