New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding return hash and fixing event tenses #417

Merged

tynes merged 2 commits into main from fix/return-hash

Oct 7, 2024

+15 −7

Contributor

0xng commented Oct 4, 2024

Description

Updates the token bridging section of predeploys.md to include the msgHash_ returned by the L2ToL2CrossDomainMessenger#sendMessage function.
Updates the mermaid to reflect this change. Similarly, it fixes sendERC20To to sendERC20 function name in the mermaid.
Introduces the same updates in token-bridging.md and fixes event tense.


          fix: adding return hash and fixing event tenses

aa16b85

0xng requested review from tynes, protolambda, ajsutton, sebastianst and mslipper as code owners

October 4, 2024 17:58


          fix: msgHash underscore

32fa71c

tynes approved these changes

View reviewed changes

tynes merged commit 90851b0 into main

1 check passed

tynes deleted the fix/return-hash branch

October 7, 2024 18:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tynes tynes approved these changes

protolambda Awaiting requested review from protolambda protolambda is a code owner

ajsutton Awaiting requested review from ajsutton ajsutton is a code owner

sebastianst Awaiting requested review from sebastianst sebastianst is a code owner

mslipper Awaiting requested review from mslipper mslipper is a code owner

Labels

None yet