-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/governance: create gov-token #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xfuturistic
requested review from
protolambda,
tynes,
ajsutton,
sebastianst and
mslipper
as code owners
May 29, 2024 16:59
0xfuturistic
force-pushed
the
feat/gov-token
branch
from
May 30, 2024 03:44
109b148
to
4c5bb64
Compare
0xfuturistic
changed the title
feat/gov-token: create specs
feat/governance: create gov-token
May 30, 2024
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
Can you double check this against the version of oz that is used in the monorepo? Its commit hash |
tynes
reviewed
May 30, 2024
tynes
reviewed
May 30, 2024
cairoeth
reviewed
May 30, 2024
kansas1295
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
tynes
reviewed
May 31, 2024
tynes
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create the specs for the Governance Token per https://github.com/voteagora/governor/blob/main/src/lib/OptimismToken.sol#L1869