specs: clarify system config changes

[tynes]

Description

Updates the specs to cover the system config interactions with the ecotone hardfork

[coderabbitai]

Walkthrough

Walkthrough

The changes are related to the Ecotone hardfork in a blockchain system. The hardfork involves updating system functions and configuration parameters. Specifically, a function has been renamed to reflect its post-hardfork version, and the system configuration documentation now includes an "Ecotone Activation" section with details on the transition and new constants for the hardfork. Additionally, there are updates on how to handle configuration events for Ecotone-specific fee parameters.

Changes

File Path	Change Summary
specs/derivation.md	Modified function calls, replaced setL1BlockValues with setL1BlockValuesEcotone, and added documentation related to the Ecotone hardfork activation.
specs/system_config.md	Added "Ecotone Activation" section, specified constants and rules for the hardfork activation block, and outlined handling of ConfigUpdate events related to Ecotone fee parameters.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[Inphi]

LGTM!

[semgrep-app]

Semgrep found 10 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/scripts/libraries/LibSort.sol: L506, L387, L370, L353, L348, L331, L314, L279, L273, L267

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 40 sol-style-notice-over-dev-natspec findings:

• packages/contracts-bedrock/src/dispute/interfaces/IFaultDisputeGame.sol: L12
• packages/contracts-bedrock/scripts/libraries/LibSort.sol: L622, L581, L535, L497, L484, L476, L468, L457, L449, L439, L433, L427, L421, L415, L409, L403, L397, L391, L386, L369, L352, L347, L330, L313, L308, L303, L283, L277, L271, L265, L260, L255, L233, L221, L214, L64, L51, L44, L16

Prefer @notice over @dev in natspec comments

_{Ignore this finding from sol-style-notice-over-dev-natspec.}

Semgrep found 1 todos_require_linear finding:

• op-node/rollup/derive/engine_queue.go: L692

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

[mslipper]

We have opted for a different solution that obviates the need for the system config to be modified as part of Ecotone. Closing this PR.