-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-service/txmgr: Add threshold to gas price increase limiter #8699
Conversation
WalkthroughWalkthroughThe update introduces a new configuration parameter to manage gas fee limits more flexibly in Ethereum transaction management. It refactors gas price adjustment logic and adds a threshold to bypass certain limits for fees below a specified amount. The changes are spread across CLI configurations and the transaction manager's logic, including new tests to verify the functionality. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
188c21f
to
3773c53
Compare
89b16aa
to
5201a00
Compare
5201a00
to
b5232ac
Compare
Description
Adds a new configuration parameter
fee-limit-threshold
that sets a lower threshold below which the multiplier limiting set byfee-limit-multiplier
is not applied.The default is set to 100 Gwei, which should be a sane default on mainnet. On testnets, the threshold can probably be set higher.
Tests
Extended the multiplier limit tests to tests both cases, with and without a threshold.
Additional context
This allows for arbitrary fee bumps below a threshold, which is particularly useful on testnets where very-low fee conditions might quickly lead to a situation where the mutliplier limit is unnecessarily applied.
We're recently seeing Goerli safe head halts because of the limit multiplier being applied during either very low fee conditions, or during basefee hikes.