Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node/p2p: Fix deleteRecord to return nil if store.Delete succeeds #8211

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

sebastianst
Copy link
Member

Description

If deletion in the underlying store returns nil, deleteRecord should also return nil.

Tests

None (yet)

@sebastianst sebastianst requested a review from a team as a code owner November 20, 2023 22:55
@sebastianst sebastianst requested a review from Inphi November 20, 2023 22:55
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #8211 (7ffa3f7) into develop (2e35a8f) will increase coverage by 5.95%.
Report is 11 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8211      +/-   ##
===========================================
+ Coverage    53.44%   59.39%   +5.95%     
===========================================
  Files          162       86      -76     
  Lines         6040     1931    -4109     
  Branches       964      438     -526     
===========================================
- Hits          3228     1147    -2081     
+ Misses        2690      698    -1992     
+ Partials       122       86      -36     
Flag Coverage Δ
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests 59.39% <ø> (-1.87%) ⬇️
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 82 files with indirect coverage changes

@mslipper
Copy link
Collaborator

CI is fixed in #8213.

@sebastianst sebastianst removed the request for review from Inphi November 21, 2023 18:58
@sebastianst sebastianst added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@sebastianst sebastianst added this pull request to the merge queue Nov 21, 2023
Merged via the queue into develop with commit 521053c Nov 21, 2023
60 checks passed
@sebastianst sebastianst deleted the seb/fix-deleteRecord branch November 21, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants