Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-service: Add unit tests for verifying receipts #8066

Merged
merged 1 commit into from
Nov 8, 2023
Merged

op-service: Add unit tests for verifying receipts #8066

merged 1 commit into from
Nov 8, 2023

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Nov 7, 2023

Description

Adds unit tests to cover the validateReceipts method.

@ajsutton ajsutton requested a review from a team as a code owner November 7, 2023 00:41
@ajsutton
Copy link
Contributor Author

ajsutton commented Nov 7, 2023

Also logged #8069 to add some tests based on actual example data from the various fetching methods (as opposed to this white box testing approach using very synthetic data).

@ajsutton ajsutton added this pull request to the merge queue Nov 8, 2023
Merged via the queue into develop with commit 3ed0891 Nov 8, 2023
59 checks passed
@ajsutton ajsutton deleted the aj/test-receipt-verification branch November 8, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trianglesphere trianglesphere trianglesphere approved these changes

@refcell refcell Awaiting requested review from refcell refcell is a code owner automatically assigned from ethereum-optimism/go-reviewers

@protolambda protolambda Awaiting requested review from protolambda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajsutton @trianglesphere