feat: Rewrite natspec checker in Go #12191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
clabby
requested changes
Sep 28, 2024
packages/contracts-bedrock/scripts/checks/semver-natspec/main.go
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/checks/semver-natspec/main.go
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/checks/semver-natspec/main.go
Outdated
Show resolved
Hide resolved
mslipper
force-pushed
the
feat/go-natspec-check
branch
from
396c536 to
18255f4
Compare
Rewrites the `semver-natspec-check-no-build` Just command in Go to reduce runtime. This PR reduces runtime for this check from ~1m30s to about 3 seconds post-compilation.
mslipper
force-pushed
the
feat/go-natspec-check
branch
from
18255f4 to
550eb12
Compare
clabby
approved these changes
Sep 28, 2024
packages/contracts-bedrock/scripts/checks/semver-natspec/main.go
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/checks/semver-natspec/main.go
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat: Rewrite natspec checker in Go Rewrites the `semver-natspec-check-no-build` Just command in Go to reduce runtime. This PR reduces runtime for this check from ~1m30s to about 3 seconds post-compilation. * remove old script * add unit tests * rename test * review updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the
semver-natspec-check-no-buildJust command in Go to reduce runtime. This PR reduces runtime for this check from ~1m30s to about 3 seconds post-compilation.