Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-proposer,challenger: start/stop balance-metrics like op-batcher #7684

Closed
protolambda opened this issue Oct 14, 2023 · 2 comments
Closed

op-proposer,challenger: start/stop balance-metrics like op-batcher #7684

protolambda opened this issue Oct 14, 2023 · 2 comments
Assignees
@protolambda
Labels
A-op-challenger Area: op-challenger A-op-proposer Area: op-proposer A-op-service Area: op-service

Comments

@protolambda
Copy link
Contributor

StartBalanceMetrics in op-batcher creates a background loop that can be closed gracefully. This same pattern should be applied to the proposer/challenger, so the loop is closed before the RPC clients are closed.

See #7682 for context.
@protolambda protolambda added A-op-challenger Area: op-challenger A-op-proposer Area: op-proposer A-op-service Area: op-service labels Oct 14, 2023
@protolambda protolambda self-assigned this Oct 14, 2023
@joohhnnn joohhnnn mentioned this issue Nov 5, 2023
Merged
@smartcontracts
Copy link
Contributor

Was this fixed?

@protolambda
Copy link
Contributor Author

fixed in #8235
and #8040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protolambda protolambda

Labels
A-op-challenger Area: op-challenger A-op-proposer Area: op-proposer A-op-service Area: op-service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smartcontracts @protolambda