Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an oldAddress param to AddressSet event #625

Closed
laizy opened this issue Apr 26, 2021 · 2 comments
Closed

Add an oldAddress param to AddressSet event #625

laizy opened this issue Apr 26, 2021 · 2 comments
Labels
C-feature Category: features

Comments

@laizy
Copy link

laizy commented Apr 26, 2021

Is your feature request related to a problem? Please describe.

Currently, the AddressSet event is defined as:

 event AddressSet(
        string _name,
        address _newAddress
    );

But the data-transport-layer service wants the old address, so have to do some searching to find the previous address set event,
which makes the code more complex and is not efficient enough.

Describe the solution you'd like
Add oldAddress param to the events.

 event AddressSet(
        string _name,
        address _newAddress,
       address _oldAddress
    );
@smartcontracts
Copy link
Contributor

100% agree with this. I had a PR that made this exact change in our old contracts repo: https://github.com/ethereum-optimism/contracts/pull/224/files. We should make this change ASAP.

@snario snario changed the title consider add an oldAddress param to AddressSet event Add an oldAddress param to AddressSet event Apr 26, 2021
@smartcontracts
Copy link
Contributor

Closed by #820, will be released in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: features
Projects
None yet
Development

No branches or pull requests

2 participants