Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make devnet-up is broken #12354

Closed
samlaf opened this issue Oct 7, 2024 · 1 comment · Fixed by #12364
Closed

make devnet-up is broken #12354

samlaf opened this issue Oct 7, 2024 · 1 comment · Fixed by #12364

Comments

@samlaf
Copy link
Contributor

samlaf commented Oct 7, 2024

Bug Description

make devnet-up
results in this error:

Traceback (most recent call last):
  File "/Users/samlaf/devel/eigenlayer/da-integrations/optimism/./bedrock-devnet/main.py", line 9, in <module>
    main()
  File "/Users/samlaf/devel/eigenlayer/da-integrations/optimism/./bedrock-devnet/main.py", line 5, in main
    devnet.main()
  File "/Users/samlaf/devel/eigenlayer/da-integrations/optimism/bedrock-devnet/devnet/__init__.py", line 120, in main
    devnet_deploy(paths)
  File "/Users/samlaf/devel/eigenlayer/da-integrations/optimism/bedrock-devnet/devnet/__init__.py", line 250, in devnet_deploy
    l2_output_oracle = addresses['L2OutputOracleProxy']
                       ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'L2OutputOracleProxy'
make: *** [devnet-up] Error 1

Environment Information:

on develop branch

Configurations:

Logs:

Additional context

Think this is the culprit https://github.com/ethereum-optimism/optimism/pull/11817/files#diff-d5b1923bb59d7a16b2affecb73b46f01db70d432a231d3ef5db751c4a2e42c5bL703: seems like the saving of the output oracle to addresses.json file was removed. Guessing this is just a mistake and we need to add it back, but not sure what this new interface is supposed to do. Maybe this is intended and its init.py which needs to be changes to remove this reading of L2outputoracleproxy?

@tynes
Copy link
Contributor

tynes commented Oct 7, 2024

We should add a check in the python script so that the L2OutputOracle{Proxy} are optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants