-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptimismMintableERC20: Add permit support + native permit2 support #11880
Comments
|
Thanks @marktoda! One follow up: What's the value of standard ERC2612 permit if permit2 is directly integrated? It seems to me permit2 is a superset of permit. I'm ok with adding both—I see POL has both as well—just curious if there's a different use case for permit vs. permit2, or if it's just to give users/devs more options? |
@marktoda can you confirm that we should enable this setting to |
Add
permit
support to theOptimismMintableERC20
token implementation. This can easily be done using theERC20Permit
contract in openzeppelin. Also add native support forpermit2
by enforcing that theallowance
forpermit2
always returnstype(uint256).max
.The text was updated successfully, but these errors were encountered: