Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log downloading for sync integration tests #1095

Closed
smartcontracts opened this issue Jun 15, 2021 · 1 comment · Fixed by #1098
Closed

Add log downloading for sync integration tests #1095

smartcontracts opened this issue Jun 15, 2021 · 1 comment · Fixed by #1098

Comments

@smartcontracts
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Seems like we've recently added sync tests to our integration tests: https://github.com/ethereum-optimism/optimism/blob/develop/.github/workflows/sync-tests.yml. However, the sync tests do not upload the logs as artifacts to GitHub like the integration tests do. This makes it very difficult to debug the tests.

Describe the solution you'd like
I'd like to see these lines added to the sync tests:

- name: Collect docker logs on failure
if: failure()
uses: jwalton/gh-docker-logs@v1
with:
images: 'ethereumoptimism/builder,ethereumoptimism/hardhat,ethereumoptimism/deployer,ethereumoptimism/data-transport-layer,ethereumoptimism/l2geth,ethereumoptimism/message-relayer,ethereumoptimism/batch-submitter,ethereumoptimism/l2geth,ethereumoptimism/integration-tests'
dest: './logs'
- name: Tar logs
if: failure()
run: tar cvzf ./logs.tgz ./logs
- name: Upload logs to GitHub
if: failure()
uses: actions/upload-artifact@master
with:
name: logs.tgz
path: ./logs.tgz

@annieke
Copy link
Contributor

annieke commented Jun 15, 2021

added to #981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants