Holocene: handle Holocene l1 attributes in l1 data fee computation #384
+87
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
changed the title
roberto-bayardo
force-pushed
the
holocene-l1-attributes
branch
from
34ec9a8 to
99df6a5
Compare
roberto-bayardo
force-pushed
the
holocene-l1-attributes
branch
from
99df6a5 to
5ea1fb3
Compare
sebastianst
reviewed
Sep 27, 2024
sebastianst
approved these changes
Sep 30, 2024
roberto-bayardo
added a commit
to roberto-bayardo/op-geth
that referenced
this pull request
Oct 1, 2024
…ation (ethereum-optimism#384)" This reverts commit c283254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Holocene introduces a new L1 attributes format which needs to be properly parsed in the L1 cost function calculation, even though in this part of the code, the new attributes do not affect the computation.
Tests
Added unit tests to confirm Holocene-style l1 attributes are handled properly after the Holocene upgrade within l1 data fee related code, and also that Ecotone-style attributes remain handled without error to support the fact that the first Holocene block will have the older style L1 attributes.
Metatdata
ethereum-optimism/specs#340