Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding PolySwarm #997

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

scsich
Copy link

@scsich scsich commented Nov 21, 2024

Description
Added PolySwarm (NCT) token to data folder

@scsich scsich requested review from wbnns and a team as code owners November 21, 2024 14:38
@wbnns wbnns self-assigned this Nov 27, 2024
@wbnns wbnns added the base label Nov 27, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scsich

Hello, thanks for the PR! Could you please ensure the logo file conforms to the required format?

https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#add-a-logo-to-your-folder

@scsich
Copy link
Author

scsich commented Dec 2, 2024

@wbnns thanks for this. Adjusting to 256x256 (assuming that is max, unclear in https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#add-a-logo-to-your-folder). Let me know if further changes needed.

@wbnns
Copy link
Member

wbnns commented Dec 4, 2024

@scsich

Thanks for the update! Apologies if it wasn't clear in the README, the logo actually needs to be named logo.svg. This needs to be updated on this PR since the name is polyswarm.svg. Hope that helps clarify!

@scsich
Copy link
Author

scsich commented Dec 5, 2024

@wbnns thanks for the clarification, makes sense now. Appreciate the follow up.

@scsich
Copy link
Author

scsich commented Dec 9, 2024

Hi @wbnns checking if this is all good now?

@wbnns
Copy link
Member

wbnns commented Dec 10, 2024

@scsich

Hello, thank you for updating the logo. We just ran CI/CD again and unfortunately it is still failing, this time with a different issue:

error: NCT on chain ethereum token 0x9E46A38F5DaaBe8683E10793b06749EEF7D733d1 has incorrect name. Got Nectar

You can use a token override to fix this. Here is a link to the README with details on how to do this:
https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#per-token-overrides

If you need further help, just let us know. 👍

@scsich
Copy link
Author

scsich commented Dec 10, 2024

Hi @wbnns for the highlight. I dropped the name overrride in there, happy to kick CI and/or have you do it if internal. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants