-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding PolySwarm #997
base: master
Are you sure you want to change the base?
adding PolySwarm #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the PR! Could you please ensure the logo file conforms to the required format?
@wbnns thanks for this. Adjusting to 256x256 (assuming that is max, unclear in https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#add-a-logo-to-your-folder). Let me know if further changes needed. |
Thanks for the update! Apologies if it wasn't clear in the README, the logo actually needs to be named |
@wbnns thanks for the clarification, makes sense now. Appreciate the follow up. |
Hi @wbnns checking if this is all good now? |
Hello, thank you for updating the logo. We just ran CI/CD again and unfortunately it is still failing, this time with a different issue:
You can use a token override to fix this. Here is a link to the README with details on how to do this: If you need further help, just let us know. 👍 |
Hi @wbnns for the highlight. I dropped the name overrride in there, happy to kick CI and/or have you do it if internal. Thanks! |
Description
Added PolySwarm (NCT) token to data folder