OP Stack SOLC update from 0.8.15 to 0.8.25 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmadiMichael
changed the title
smartcontracts
approved these changes
Oct 3, 2024
|
You have my approval but please also get approval from @mds1 before merging |
|
Oh and @maurelian too |
maurelian
reviewed
Oct 3, 2024
mds1
reviewed
Oct 3, 2024
mds1
reviewed
Oct 3, 2024
mds1
reviewed
Oct 3, 2024
mds1
reviewed
Oct 3, 2024
mds1
reviewed
Oct 3, 2024
| #### Gas Optimization | ||
|
|
||
| - Unchecked loop increments (>= 0.8.22) | ||
| - Use `mcopy` instead of `mload`/`mstore` loop when copying byte arrays (>= 0.8.25) |
There was a problem hiding this comment.
mcopy will also simplify our proofs and may improve performance there as a result
There was a problem hiding this comment.
Not sure if you suggest I add this or just a comment...
mds1
reviewed
Oct 3, 2024
mds1
approved these changes
Oct 3, 2024
maurelian
reviewed
Oct 3, 2024
maurelian
reviewed
Oct 3, 2024
maurelian
approved these changes
Oct 3, 2024
maurelian
reviewed
Oct 3, 2024
maurelian
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This covers solidity version upgrade of all OP Stack smart contracts from 0.8.15 code to 0.8.25.
Metadata
Fixes ethereum-optimism/optimism#11527