We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I was reading through the source code for the maker bot, and it seems as though there was a line copied without replacing the variable name. See L92.
# Create sell orders for sellordernr in range(1,sellOrdersToPlace+1): price = midmarket + sellordernr * midmarket * marginfactor amount = sellVolumeToPlace / sellOrdersToPlace ... # Create buy orders for sellordernr in range(1,sellOrdersToPlace+1): price = midmarket - sellordernr * midmarket * marginfactor amount = float(buyVolumeToPlace) / float(price) / float(buyOrdersToPlace) ...
Suggested fix:
L92-93 - for sellordernr in range(1,sellOrdersToPlace+1): - price = midmarket - sellordernr * midmarket * marginfactor + for buyordernr in range(1,buyOrdersToPlace+1): + price = midmarket - buyordernr * midmarket * marginfactor
Compare to maker.js
for (let i = 0; i < sellOrdersToPlace; i += 1) { const price = midMarket + ((i + 1) * midMarket * 0.05); const amount = service.toEth(sellVolumeToPlace / sellOrdersToPlace, token.decimals); ... for (let i = 0; i < buyOrdersToPlace; i += 1) { const price = midMarket - ((i + 1) * midMarket * 0.05); const amount = service.toEth(buyVolumeToPlace / price / buyOrdersToPlace, token.decimals);
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I was reading through the source code for the maker bot, and it seems as though there was a line copied without replacing the variable name. See L92.
Suggested fix:
Compare to maker.js
The text was updated successfully, but these errors were encountered: