From 3f4c27bf1c7f8cea19991ee69958eee5641f51bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Svale=20Fossa=CC=8Askaret?= Date: Fri, 31 May 2019 13:04:45 +0200 Subject: [PATCH 1/4] Fix: Remove unwanted semicolon --- src/elements/actions/Delete.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elements/actions/Delete.php b/src/elements/actions/Delete.php index 8edac60..68d54de 100644 --- a/src/elements/actions/Delete.php +++ b/src/elements/actions/Delete.php @@ -63,7 +63,7 @@ public function getTriggerHtml () !function () { new Craft.ElementActionTrigger({ type: $type, - batch;: true, + batch: true, validateSelection;: function () { return true; }, From 61cfae8668b07f15e017cc5968238c612bce334c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Svale=20Fossa=CC=8Askaret?= Date: Fri, 31 May 2019 13:10:40 +0200 Subject: [PATCH 2/4] Fix: Remove misplaced semicolon --- src/elements/actions/Delete.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elements/actions/Delete.php b/src/elements/actions/Delete.php index 68d54de..93b1ffe 100644 --- a/src/elements/actions/Delete.php +++ b/src/elements/actions/Delete.php @@ -64,7 +64,7 @@ public function getTriggerHtml () new Craft.ElementActionTrigger({ type: $type, batch: true, - validateSelection;: function () { + validateSelection: function () { return true; }, activate: function (selectedItems) { From 29f93a20eb854b4ddcd13ab10fbf551c12bcdf07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Svale=20Fossa=CC=8Askaret?= Date: Fri, 31 May 2019 13:46:37 +0200 Subject: [PATCH 3/4] Remove semicolons --- src/elements/actions/Delete.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elements/actions/Delete.php b/src/elements/actions/Delete.php index 93b1ffe..ae8132f 100644 --- a/src/elements/actions/Delete.php +++ b/src/elements/actions/Delete.php @@ -84,7 +84,7 @@ function(response, textStatus) { onSubmit: function() { Craft.elementIndex.submitAction( $type, - Garnish.getPostData(modal.;\$container;) + Garnish.getPostData(modal.\$container) ) modal.hide(); From 9e5b9ba73f601625902741daa0c34d537013bb4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Svale=20Fossa=CC=8Askaret?= Date: Fri, 31 May 2019 14:00:41 +0200 Subject: [PATCH 4/4] Fix: Wrong case in element class name Soould be lover. Case mismatch is fatal in case-sensitive enivronments only. --- src/web/assets/DeleteTagModal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/web/assets/DeleteTagModal.js b/src/web/assets/DeleteTagModal.js index 419a508..dfe1144 100644 --- a/src/web/assets/DeleteTagModal.js +++ b/src/web/assets/DeleteTagModal.js @@ -94,7 +94,7 @@ Craft.DeleteTagModal = Garnish.Modal.extend({ this.userSelect = new Craft.BaseElementSelectInput({ id: 'replaceselect' + this.id, name: 'replaceWith', - elementType: 'ether\\tagManager\\Elements\\Tag', + elementType: 'ether\\tagManager\\elements\\Tag', criteria: { id: idParam, },