Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration runs on every request #190

Closed
sebastian-lenz opened this issue Jul 29, 2019 · 0 comments
Closed

Migration runs on every request #190

sebastian-lenz opened this issue Jul 29, 2019 · 0 comments

Comments

@sebastian-lenz
Copy link

sebastian-lenz commented Jul 29, 2019

The plugin currently runs the latest migration on every request right in the init function, please see:

https://github.com/ethercreative/simplemap/blob/v3/src/SimpleMap.php#L48

I don't think this is intentional and looks like some accidentally commited test code. Furthermore, running a migration right here causes errors cause other plugins have not initialized yet and the migration cycles through all fields.

@Tam Tam closed this as completed in 0530168 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant