-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password parameter when creating new pad #351
Comments
This would be a nice functionality! |
I'd love to see that feature in a future release! |
Either way you would need to use the API to do this so if I was you I would familiarize yourself with the API and create your own front end request to apply security. |
The pad-creation hook in the new plugin API draft looks promising, but I'm guessing that's some time away.. I had hoped this would be possible without introducing a new dependency by using the HTTP API + whatever language, but I could see myself going that route eventually if need be. |
important feature, for me this is the only feature that keeps me from switching to etherpad-lite. |
This will be a plugin one day |
+1. I believe that currently only group pads may have passwords? If this becomes a plugin someday, it implies that "normal" pads must be allowed to have passwords. Does it make sense to go ahead and remove that restriction from core? I can't think of any downside. |
The plugins API seems to have come a long way since. Could this issue be retagged as a Plugin Request? I'd also like to expand on @jhollinger 's last note: Would it be possible to allow "normal" (non-group) pads to have passwords? This restriction has meant one can not simply password protect a "normal" pad; one has to go all-in and manage Authors, Groups, Sessions & Pads before one is able to password protect a single pad. =\ |
Please create a vote for this plugin / feature on http://etherpad.idea.informer.com/ |
So here is how I see this working..
We can do this a ghetto way just doing 99% of it on the client or we can attempt to create some sort of integration with the auth mechanism.. I'd suggest the latter which makes it a bigger job than just a bunch of hidden divs.. |
I tried to work on this feature, but then I realized that there are serious limitations. But maybe I'm wrong:
I still feel like this feature would make sense somehow. But before I seriously start working on it I would like to understand the thread model. |
I thought so too, but started reconsidering this because of the HTTP "referer" situation (leaking your link to external sites by following URLs there!), also see #1603 and recently #3636 . Thought this is relevant to mention here. |
Closing this as we're moving security outside of Etherpad. |
On 20-05-06 09:00:00, John McLear wrote:
Closing this as we're moving security outside of Etherpad.
@JohnMcLear Mind to elaborate?
|
The concept that Etherpad should store/maintain etc. passwords is IMHO bad practice. Etherpad is not an authentication platform. User management & Authentication platforms exist (think Auth0) and do a very specific job very well. 50% of Etherpad's technical debt is this horrible auth etc. so we're ripping it out so we can focus on the features users want. This means plugins will provide different auth mechanisms (including password) and they can be responsible for password storage etc. See ep_hash_auth for example... |
Would it be possible to add a password parameter when creating a new pad? This way passwords can trivially be managed by users of an etherpad installation themselves, without needing an external management site using the API. The welcome page could then also be updated to add a password field to make it easy for users to use this functionality.
I'd envision this as a one time set operation, after which the user is left to distribute the password themselves, without any further password management.
The text was updated successfully, but these errors were encountered: