Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password parameter when creating new pad #351

Closed
timtebeek opened this issue Jan 22, 2012 · 17 comments
Closed

Add password parameter when creating new pad #351

timtebeek opened this issue Jan 22, 2012 · 17 comments

Comments

@timtebeek
Copy link

Would it be possible to add a password parameter when creating a new pad? This way passwords can trivially be managed by users of an etherpad installation themselves, without needing an external management site using the API. The welcome page could then also be updated to add a password field to make it easy for users to use this functionality.
I'd envision this as a one time set operation, after which the user is left to distribute the password themselves, without any further password management.

@riseuplabs
Copy link

This would be a nice functionality!

@dora71
Copy link

dora71 commented Jan 29, 2012

I'd love to see that feature in a future release!

@JohnMcLear
Copy link
Member

Either way you would need to use the API to do this so if I was you I would familiarize yourself with the API and create your own front end request to apply security.

@timtebeek
Copy link
Author

The pad-creation hook in the new plugin API draft looks promising, but I'm guessing that's some time away..

I had hoped this would be possible without introducing a new dependency by using the HTTP API + whatever language, but I could see myself going that route eventually if need be.

@snaut
Copy link

snaut commented Jan 30, 2012

important feature, for me this is the only feature that keeps me from switching to etherpad-lite.

@Pita
Copy link
Contributor

Pita commented Jan 30, 2012

This will be a plugin one day

@jhollinger
Copy link
Contributor

+1. I believe that currently only group pads may have passwords? If this becomes a plugin someday, it implies that "normal" pads must be allowed to have passwords. Does it make sense to go ahead and remove that restriction from core? I can't think of any downside.

@timtebeek
Copy link
Author

The plugins API seems to have come a long way since. Could this issue be retagged as a Plugin Request?

I'd also like to expand on @jhollinger 's last note: Would it be possible to allow "normal" (non-group) pads to have passwords? This restriction has meant one can not simply password protect a "normal" pad; one has to go all-in and manage Authors, Groups, Sessions & Pads before one is able to password protect a single pad. =\

@JohnMcLear
Copy link
Member

Please create a vote for this plugin / feature on http://etherpad.idea.informer.com/

@JohnMcLear
Copy link
Member

So here is how I see this working..
User hits up http://blah.com/p/jdflkjskldfjsdf?password=true

  1. Because password=true we attempt to set a password
  2. first we check for an existing password, if none exists we should a dialog to provide a password for this pad...
  3. Future users that visit this pad are required to type in a password to access the pad contents..

We can do this a ghetto way just doing 99% of it on the client or we can attempt to create some sort of integration with the auth mechanism.. I'd suggest the latter which makes it a bigger job than just a bunch of hidden divs..

@JohnMcLear
Copy link
Member

@xi
Copy link

xi commented Jun 18, 2016

I tried to work on this feature, but then I realized that there are serious limitations. But maybe I'm wrong:

  • If anyone can set a password on a normal (non-group) pad, it is trivial to block other people from their own pads (DOS). So setting a password needs to be limited to pad creation.
  • Pads are not listed anywhere, so they are protected by a "you need to know the URL" mechanism. I don't really see how "you need to know the password" is significantly more secure.

I still feel like this feature would make sense somehow. But before I seriously start working on it I would like to understand the thread model.

@dcht00
Copy link
Collaborator

dcht00 commented Oct 1, 2019

* Pads are not listed anywhere, so they are protected by a "you need to know the URL" mechanism. I don't really see how "you need to know the password" is significantly more secure.

I thought so too, but started reconsidering this because of the HTTP "referer" situation (leaking your link to external sites by following URLs there!), also see #1603 and recently #3636 . Thought this is relevant to mention here.

@muxator
Copy link
Contributor

muxator commented Nov 24, 2019

@dcht00: Etherpad 1.8.0 will change its referrer policy and stop sending referer.

Discussion: #3636

@JohnMcLear
Copy link
Member

Closing this as we're moving security outside of Etherpad.

@geor-g
Copy link

geor-g commented May 6, 2020 via email

@JohnMcLear
Copy link
Member

The concept that Etherpad should store/maintain etc. passwords is IMHO bad practice. Etherpad is not an authentication platform.

User management & Authentication platforms exist (think Auth0) and do a very specific job very well. 50% of Etherpad's technical debt is this horrible auth etc. so we're ripping it out so we can focus on the features users want.

This means plugins will provide different auth mechanisms (including password) and they can be responsible for password storage etc. See ep_hash_auth for example...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants