Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 'postOp' revert with <32 bytes size #289

Closed
forshtat opened this issue May 23, 2023 · 1 comment · Fixed by #293
Closed

Handle 'postOp' revert with <32 bytes size #289

forshtat opened this issue May 23, 2023 · 1 comment · Fixed by #293

Comments

@forshtat
Copy link
Collaborator

As mentioned here:

pimlicolabs/erc20-paymaster#2 (comment)
@leekt leekt mentioned this issue May 30, 2023
Merged
@drortirosh
Copy link
Contributor

Right.
It is an inconsistency of hardhat with the spec:
hardhat reverts on returndatacopy if there is no return data, but geth silently returns..
Yes, we SHOULD check the returndatasize first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: entrypoint does not revert even first postOp reverts with short … leekt/account-abstraction
2 participants
@drortirosh @forshtat