Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Python 3.13 support #74

Closed
remyroy opened this issue Jun 25, 2024 · 4 comments
Closed

Prepare for Python 3.13 support #74

remyroy opened this issue Jun 25, 2024 · 4 comments

Comments

@remyroy
Copy link
Member

remyroy commented Jun 25, 2024

See if we can test this on Python 3.13 early or add it to the CI to see if packages are good to go and everything works.

Python is slated for an October 1st, 2024 release date. It's currently available as a prerelease version.

@remyroy remyroy changed the title Prepare for Python 3.13 support. Prepare for Python 3.13 support Jul 10, 2024
@yorickdowne
Copy link

yorickdowne commented Aug 25, 2024

The test_existing_mnemonic_bls_withdrawal test fails.

Failed test:

    def test_existing_mnemonic_bls_withdrawal() -> None:
        # Prepare folder
        my_folder_path = os.path.join(os.getcwd(), 'TESTING_TEMP_FOLDER')
        clean_key_folder(my_folder_path)
        if not os.path.exists(my_folder_path):
            os.mkdir(my_folder_path)
    
        runner = CliRunner()
        inputs = [
            'TREZOR',
            'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about',
            '2', '2', '5', 'mainnet', 'MyPassword', 'MyPassword']
        data = '\n'.join(inputs)
        arguments = [
            '--language', 'english',
            '--ignore_connectivity',
            'existing-mnemonic',
            '--withdrawal_address', '',
            '--folder', my_folder_path,
            '--mnemonic_password', 'TREZOR',
        ]
        result = runner.invoke(cli, arguments, input=data)
    
>       assert result.exit_code == 0
E       AssertionError: assert 1 == 0
E        +  where 1 = <Result ValueError('Checksum message error')>.exit_code

tests/test_cli/test_existing_mnemonic.py:38: AssertionError

@yorickdowne
Copy link

Test succeeds when running it again. That is not amazing. Do we have a race condition somewhere?

@yorickdowne yorickdowne mentioned this issue Aug 25, 2024
@remyroy
Copy link
Member Author

remyroy commented Aug 27, 2024

Monitor https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json and check for when Python 3.13 is fully released on or about October 1st, 2024. I just added a calendar reminder.

Once released, we should update our ci-runner to include the proper 3.13 version in the test matrix.

@remyroy
Copy link
Member Author

remyroy commented Sep 6, 2024

We are now well prepared to support Python 3.13.

@remyroy remyroy closed this as completed Sep 6, 2024
@remyroy remyroy mentioned this issue Sep 10, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants