-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplementation of local band-to-tridiagonal #938
Conversation
Nice @rasolca! Any idea about the scaling so far (I'm just eager to hear the results, don't worry if you don't have that yet)? For the |
Not yet... still trying to make the local
|
eac7a63
to
c5cede7
Compare
7037cc5
to
b26de26
Compare
…stributed implementation)
b26de26
to
372e46f
Compare
cscs-ci run |
c60310a
to
1c93733
Compare
Co-authored-by: Mikael Simberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved modulo the formatting violations.
cscs-ci run |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #938 +/- ##
==========================================
+ Coverage 93.20% 94.73% +1.53%
==========================================
Files 136 122 -14
Lines 8327 7504 -823
Branches 1081 1023 -58
==========================================
- Hits 7761 7109 -652
+ Misses 391 240 -151
+ Partials 175 155 -20
|
Implementation without
let_value
.To me it looks simpler and more readable compared to other attempt with
let_value
(see #939), but introduce a little trick with ashared_ptr
to allow to share the vector of tiles.The new implementation is 45-50% faster (tested 20k, 30k and 40k).