Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MatrixRef to take a sub-matrix from an existing Matrix #934

Merged
merged 19 commits into from
Jul 28, 2023
Merged

Add MatrixRef to take a sub-matrix from an existing Matrix #934

merged 19 commits into from
Jul 28, 2023

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Jul 12, 2023 •
edited
Loading

This adds a MatrixRef class which takes an existing Matrix, offset, and size to give sender access to the sub-distribution defined by offset and size. At least for this PR MatrixRef will stay a separate type. It's not clear to me how to cleanly make MatrixRef and Matrix the same type without ugliness in the implementation, and without confusing the guarantees that the types give.

@msimberg msimberg added this to the Optimizations milestone Jul 12, 2023
@msimberg msimberg self-assigned this Jul 12, 2023
@msimberg msimberg marked this pull request as draft July 12, 2023 08:03
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg mentioned this pull request Jul 12, 2023
Open
5 tasks
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg requested a review from albestro July 13, 2023 07:37
@msimberg msimberg marked this pull request as ready for review July 13, 2023 07:37
@msimberg msimberg requested a review from rasolca July 13, 2023 07:37
albestro
albestro approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimberg
Copy link
Collaborator Author

cscs-ci run

rasolca
rasolca reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@rasolca rasolca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would merge this PR and start using it. In this way we can fully realize if the API is ok or need tweaking.

But I would move MatrixRef to internal namespace, and move back in a later PR when we are confident about the API.

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg requested a review from rasolca July 28, 2023 10:53
@rasolca rasolca merged commit 7114b18 into eth-cscs:master Jul 28, 2023
github-actions bot pushed a commit that referenced this pull request Jul 28, 2023
@rasolca
Doc Add MatrixRef to take a sub-matrix from an existing Matrix (#934
6403d87 
)
@msimberg msimberg deleted the sub-distribution branch July 28, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albestro albestro albestro approved these changes

@rasolca rasolca rasolca approved these changes

Assignees

@msimberg msimberg

Labels
Priority:High
Projects
DLA-F Planning
Archived in project
Milestone
Optimizations
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @rasolca @albestro