Matrix Data Reshuffling (matrix re-distribute) #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
reviewed
Jul 12, 2023
albestro
commented
Jul 13, 2023
albestro
commented
Jul 13, 2023
rasolca
reviewed
Jul 19, 2023
albestro
force-pushed
the
alby/matrix-data-reshuffling
branch
from
b02a104
to
50f89dc
Compare
|
After #935 got merged, it was a quick change to move from retiled to matrix and I was also able to fix const-correctness 😉 Apart small details, this should be ready for final review. |
msimberg
approved these changes
Jul 20, 2023
|
cscs-ci run |
|
There are deadlocks in the CUDA tests. |
|
cscs-ci run |
…block which is not currently supported
albestro
force-pushed
the
alby/matrix-data-reshuffling
branch
from
4afd7f2
to
beea7e1
Compare
|
cscs-ci run |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 93.30% 93.34% +0.03%
==========================================
Files 135 135
Lines 8397 8440 +43
Branches 1085 1089 +4
==========================================
+ Hits 7835 7878 +43
Misses 386 386
Partials 176 176
|
msimberg
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #919
Simple implementation of a copy function that allows to re-distribute a matrix with a different tile size.
Currently, we concentrated on a small subset of configurations by adding some constraints, that should not represent a problem for the use-cases we'd like to try, but simplify the first implementation.
Constraints:
ranks(grid_in) == ranks(grid_out)Note:
Current implementation uses
RetiledMatrix(which simplifies the work a lot!), which we know it is a temporary solution waiting for the refactoring. For this reason, I had to relax the const-correctness of the input arguments of the newcopyfunction, because currentlyRetiledMatrix<const T>is not supported.