Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TridiagSolver (distributed): "bulkerify" rank1 problem solution #904

Merged
merged 29 commits into from
Jul 7, 2023
Merged

TridiagSolver (distributed): "bulkerify" rank1 problem solution #904

merged 29 commits into from
Jul 7, 2023

Commits on Jun 19, 2023

  1. minor changes

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    2fa0228 View commit details
    Browse the repository at this point in the history

  2. first step: step1 laed4 + basic structure

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    588d766 View commit details
    Browse the repository at this point in the history

  3. fix nthreads

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8f43990 View commit details
    Browse the repository at this point in the history

  4. embed assembleDistEvalsVec in bulk

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    df4739a View commit details
    Browse the repository at this point in the history

  5. embed step2 in bulk

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e5e463e View commit details
    Browse the repository at this point in the history

  6. add basic version of step3 in bulk

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    399b3b5 View commit details
    Browse the repository at this point in the history

  7. remove superfluous copies

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    1679134 View commit details
    Browse the repository at this point in the history

  8. use blas::dot

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a3120c8 View commit details
    Browse the repository at this point in the history

  9. apply fix for k<=2 as done in last PR merged on master

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    ddeaefa View commit details
    Browse the repository at this point in the history

  10. last step (normalization) reduce number of communications 

    by working by column-tile-wise instead of column-element-wise
    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    55fc508 View commit details
    Browse the repository at this point in the history

  11. remove blocking mpi calls allowing yielding

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9ff7944 View commit details
    Browse the repository at this point in the history

  12. add missing barrier between multi to single threaded transition

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8b56f26 View commit details
    Browse the repository at this point in the history

  13. rename according to new guidelines + minor changes

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    17ef1b1 View commit details
    Browse the repository at this point in the history

  14. revert temporary change

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9efd932 View commit details
    Browse the repository at this point in the history

  15. minor fixes

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    cb9974c View commit details
    Browse the repository at this point in the history

  16. start factoring out bcast and remove superfluous barriers

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9401feb View commit details
    Browse the repository at this point in the history

  17. remove sync_wait for bcast (it just wait at the end of bulk) + other … 

    …changes
    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9646224 View commit details
    Browse the repository at this point in the history

  18. minor changes

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4574565 View commit details
    Browse the repository at this point in the history

  19. Update include/dlaf/eigensolver/tridiag_solver/merge.h 

    Co-authored-by: Mikael Simberg <[email protected]>
    @albestro @msimberg
    albestro and msimberg committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7c9023f View commit details
    Browse the repository at this point in the history

  20. add barrier busy wait + remove todo

    @albestro
    albestro committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    49c63fe View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. bug fix: race-condition over LAED4 workspace in case of multiple workers 

    fixed by re-using existing column workspaces, by adapting them per new
size requirements
    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    e033844 View commit details
    Browse the repository at this point in the history

  2. use make_unique instead of make_shared as suggested in #911

    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    664eb10 View commit details
    Browse the repository at this point in the history

  3. minor change: reorder communicators (row first, col second)

    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    74f47e1 View commit details
    Browse the repository at this point in the history

  4. minor comment

    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2ee1fda View commit details
    Browse the repository at this point in the history

  5. use "sub"-pipeline to force communications order on row communicator

    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a9453fd View commit details
    Browse the repository at this point in the history

  6. remove unused capture

    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    1c08795 View commit details
    Browse the repository at this point in the history

  7. clang-format

    @albestro
    albestro committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    9a7c871 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. rename all_reduce lambda as suggested

    @albestro
    albestro committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    ebe9bee View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Update include/dlaf/eigensolver/tridiag_solver/merge.h 

    Co-authored-by: Mikael Simberg <[email protected]>
    @albestro @msimberg
    albestro and msimberg authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d8fcc7a View commit details
    Browse the repository at this point in the history