-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting to pika #422
Porting to pika #422
Conversation
C++17 is the major one. The rest are additions to the sender/receiver implementation, but that doesn't affect master at all at the moment. |
ec1fe71
to
b444412
Compare
About C++17 migration of DLAF codebase, there is https://en.cppreference.com/w/cpp/error/uncaught_exception that slightly changes its API. |
Note that the move to C++17 will require that we use rather recent versions of CUDA and nvcc (>11.0.167): https://gist.github.com/ax3l/9489132 |
f100a4a
to
39052b2
Compare
142e450
to
1ee5986
Compare
2fce3c2
to
71b51ac
Compare
71b51ac
to
7d5af0f
Compare
bors try |
A few notes about the move to pika:
|
bors try |
tryAlready running a review |
bors try- |
bors try |
7d5af0f
to
4e644a6
Compare
bors try- |
bors try |
tryBuild failed: |
bors try |
tryBuild succeeded: |
This reverts commit 730980c.
bors try |
tryBuild succeeded: |
bors try |
tryBuild succeeded: |
d111adc
to
b8963a1
Compare
bors try |
tryBuild succeeded: |
Note to self: this build was meaningless since it used the cached images. I wanted to try a new commit on pika main so I'll push a commit with an updated spack hash. |
bors try |
tryBuild succeeded: |
Pika still needs a release, and the release added to the spack package, but this is ready for reviews otherwise. |
bors try |
tryBuild succeeded: |
This is the PR in preparation for the next HPX release.
Changelog:
TODO:
tag_invoke/dispatch
compatibility macrosRename tag_dispatch back to tag_invoke STEllAR-GROUP/hpx#5600
execution::then
instead oftransform
, andexecution::start_detached
instead ofdetach
(renamed)Rename execution::transform to execution::then and execution::detach to execution::start_detached STEllAR-GROUP/hpx#5644
execution::transfer
instead ofon
(renamed)Rename on execution::schedule_from, rename just_on to just_transfer, and add transfer STEllAR-GROUP/hpx#5656
Word to @msimberg for any major change (in case there are).