Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to pika #422

Merged
merged 14 commits into from
Feb 1, 2022
Merged

Porting to pika #422

merged 14 commits into from
Feb 1, 2022

Conversation

albestro
Copy link
Collaborator

@albestro albestro commented Sep 15, 2021

This is the PR in preparation for the next HPX release.

Changelog:

TODO:

Word to @msimberg for any major change (in case there are).

CMakeLists.txt Outdated Show resolved Hide resolved
spack/packages/dla-future/package.py Outdated Show resolved Hide resolved
@msimberg
Copy link
Collaborator

Word to @msimberg for any major change (in case there are).

C++17 is the major one. The rest are additions to the sender/receiver implementation, but that doesn't affect master at all at the moment.

@albestro
Copy link
Collaborator Author

About C++17 migration of DLAF codebase, there is https://en.cppreference.com/w/cpp/error/uncaught_exception that slightly changes its API.

@teonnik
Copy link
Contributor

teonnik commented Nov 4, 2021

Note that the move to C++17 will require that we use rather recent versions of CUDA and nvcc (>11.0.167): https://gist.github.com/ax3l/9489132

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 21, 2022
@msimberg msimberg changed the title Porting HPX 1.8.0 Porting to pika Jan 21, 2022
ci/.gitlab-ci.yml Outdated Show resolved Hide resolved
@msimberg
Copy link
Collaborator

A few notes about the move to pika:

  • Most of it is renaming hpx to pika
  • hpx/local headers and hpx::local namespaces have dropped local since there's no corresponding distributed
  • I've required an exact version (0.1.0) in CMake since until 1.0.0 we will not guarantee API stability (we'll follow https://semver.org/, which allows breaking changes on pre-1.0.0 versions)
  • The spack package currently points to my fork of spack. I'll replace hpx-local with pika in the upstream spack repository once I see this is working.
  • I've changed some hpx/include headers to pika/modules headers. The hpx/include headers came from distributed HPX and were meant to be replaced eventually. pika/modules are also not official public API headers, but work for now. I've opened issues to replace them with official public headers: https://github.com/pika-org/pika/issues?q=is%3Aissue+is%3Aopen+API+header+.

@msimberg
Copy link
Collaborator

bors try

@bors
Copy link

bors bot commented Jan 21, 2022

try

Already running a review

@msimberg
Copy link
Collaborator

bors try-

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 21, 2022
@msimberg
Copy link
Collaborator

bors try-

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 21, 2022
@bors
Copy link

bors bot commented Jan 21, 2022

try

Build failed:

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 24, 2022
@bors
Copy link

bors bot commented Jan 24, 2022

try

Build succeeded:

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 24, 2022
@bors
Copy link

bors bot commented Jan 24, 2022

try

Build succeeded:

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 25, 2022
@bors
Copy link

bors bot commented Jan 25, 2022

try

Build succeeded:

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 28, 2022
ci/docker/cpu-debug.yaml Show resolved Hide resolved
include/dlaf/auxiliary/norm/mc.h Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 28, 2022

try

Build succeeded:

@msimberg
Copy link
Collaborator

try

Build succeeded:

* [ci/gitlab/full-pipeline](https://gitlab.com/cscs-ci/eth-cscs/DLA-Future/-/pipelines/458562157)

Note to self: this build was meaningless since it used the cached images. I wanted to try a new commit on pika main so I'll push a commit with an updated spack hash.

@msimberg
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Jan 31, 2022
@bors
Copy link

bors bot commented Jan 31, 2022

try

Build succeeded:

@msimberg msimberg marked this pull request as ready for review January 31, 2022 12:02
@msimberg
Copy link
Collaborator

Pika still needs a release, and the release added to the spack package, but this is ready for reviews otherwise.

@msimberg
Copy link
Collaborator

msimberg commented Feb 1, 2022

bors try

bors bot added a commit that referenced this pull request Feb 1, 2022
@bors
Copy link

bors bot commented Feb 1, 2022

try

Build succeeded:

@rasolca rasolca merged commit 49b5977 into master Feb 1, 2022
@rasolca rasolca deleted the porting-hpx1.8.0 branch February 1, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants