WIP: Increment nonce to #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- silent (no tx console output) - for now simply creates empty transactions to increment nonce - throws ValueError if target nonce is below current nonce
# Conflicts: # brownie/network/account.py
|
closed in favour of #472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
WIP!
Added a method for unlocked accounts to silently increase their nonce to a higher value.
Related issue: #467
How I did it
Added the silent parameter to transactions. Created a method that will loop empty transactions until the new nonce is met.
How to verify it
Call increase_nonce_to(int) on an unlocked account.
No tests yet, discussion first.
Checklist