Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks with multiple projects get routed improperly #26

Open
AtomicTroop opened this issue Mar 1, 2016 · 5 comments
Open

Tasks with multiple projects get routed improperly #26

AtomicTroop opened this issue Mar 1, 2016 · 5 comments

Comments

@AtomicTroop
Copy link

We tag each task with a project tag and a type tag (using project tags), so an average task might have the project tags #someexampleproject and #code.
We've set phabulous to route notifications about tasks with the #someexampleproject tag to a certain slack channel. These never arrive if the tasks includes any other tags.

To summarize, phabulous seems to assume the tag rule to be this tag and nothing else while I expect it to be at least this tag. Not sure if this is intentional.

@AtomicTroop
Copy link
Author

Minor addition, it seems some tasks do get posted to the slack channel, but only if the project tag is listed before the type tag. Interestingly, the order you add these tags to a new task doesn't seem to affect the order they are listed.
We're still figuring out what situations and task add processes affect the tag order, but I don't think it should matter at all.

@etcinit
Copy link
Owner

etcinit commented Mar 3, 2016

Yeah, the bot currently only supports resolving one channel per object (task, repository, etc). This is definitely an issue when tagging something with multiple projects. I'll need to update resolver code to loop over every project attached to an object.

@blades
Copy link

blades commented Sep 12, 2017

i've got a fork here:
https://github.com/blades/phabulous
that addresses this in the maniphest resolver class if you're interested. i haven't touched any of the other resolvers, though.

@blades
Copy link

blades commented Sep 12, 2017

i've added a pull request, too. if i get a chance, i'll see if i can do anything further with the other resolvers if necessary.

@joelruns
Copy link

Somewhat related, tasks with no project tags cause Phabulous to send a message with just "(More Info)" to all channels being routed under projects: in main.yml it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants