Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cameraX" should be "cameraY" and vice versa #35

Open
jxiong21029 opened this issue Nov 10, 2024 · 0 comments
Open

"cameraX" should be "cameraY" and vice versa #35

jxiong21029 opened this issue Nov 10, 2024 · 0 comments

Comments

@jxiong21029
Copy link

In one_hot_actions() the 15th dim of the returned output is described in the code as cameraX, and the 16th dim as cameraY.

However, the actual convention of the VPT contractor dataset, as well as what it seems like the model was trained with, cameraY comes first (down is positive) and cameraX is second (right is positive). I.e. if you set dimension 15 of the actions to positive, the video generated by Oasis will have the POV look down.

So, both instances of cameraX (in ACTION_KEYS and in one_hot_actions) should be replaced with cameraY in the code, and similarly both instances of cameraY should be replaced withcameraX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant