etcdserver/api/v3rpc: remove duplicate gRPC logger set #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix
=== RUN TestEmbedEtcd
==================
WARNING: DATA RACE
Write at 0x000001df86d0 by goroutine 711:
github.com/coreos/etcd/embed.(*Config).setupLogging.func1()
/go/src/github.com/coreos/etcd/vendor/google.golang.org/grpc/grpclog/loggerv2.go:68 +0x16c
sync.(*Once).Do()
/usr/local/go/src/sync/once.go:44 +0xe1
github.com/coreos/etcd/embed.(*Config).setupLogging()
in gRPC proxy tests.
Signed-off-by: Gyuho Lee <[email protected]>
gyuho
force-pushed
the
race
branch
2 times, most recently
from
a83189e to
9b260ca
Compare
Signed-off-by: Gyuho Lee <[email protected]>
|
Still gRPC proxy tests are failing. Will investigate separate. |
|
@gyuho could we get this backported? I am running into some race conditions working on discovery repo and this resolves that. |
hexfusion
pushed a commit
to hexfusion/etcd
that referenced
this pull request
Aug 18, 2018
etcdserver/api/v3rpc: remove duplicate gRPC logger set
gyuho
added a commit
that referenced
this pull request
Aug 20, 2018
etcdserver: cherry-pick #9861 to release-3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
in gRPC proxy tests.