Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/op-guide: add missing flags, clarify "--initial*" flags #9597

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 20, 2018

@gyuho gyuho force-pushed the flag-doc branch 2 times, most recently from bd1d8b0 to 347a89a Compare April 20, 2018 18:27
Copy link
Contributor

@joelegasse joelegasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions about examples or related documentation.

@@ -312,6 +312,16 @@ The security flags help to [build a secure etcd cluster][security].

## Logging flags

### --logger
+ Specify 'zap' for structured logging or 'capnslog'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any supporting documentation pages describing each output and what they look like?

+ env variable: ETCD_LOGGER

### --log-output
+ Specify 'stdout' or 'stderr' to skip journald logging even when running under systemd, or list of comma separated output targets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the --logger question above. Are there links to supporting documentation/examples or a full list of "output targets" that could appear and how each one behaves?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelegasse Currently, we don't have example docs on etcd flags. Instead, we've only tracked what has changed with some examples here

https://github.com/coreos/etcd/blob/master/CHANGELOG-3.4.md#added-etcd

This configuration.md can be improved with more concrete examples.

@gyuho gyuho merged commit 3802866 into etcd-io:master Apr 24, 2018
@gyuho gyuho deleted the flag-doc branch April 24, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants