-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect URIs for some lease related functions in JSON API #9430
Comments
@akashbaid first of all the Swagger spec is correct technically, as it matches the code. Logically I have battled with this as well. I ended up managing the organization internally with my client to work around it. I am curious though if we could use So for example
We could then phase that out after a few minor iterations allowing folks to handle it gracefully. /cc @gyuho |
I will do a bit of testing with this soon, if it works would you like to take it on @akashbaid ? |
@hexfusion Sure. |
@akashbaid Well this is not going to be as easy as that. Leases are showing expired with timetolive, will try to dig in when I get some time but feel free to test and explore on your own. scripts/genproto.sh will regenerate the swagger etc.
|
Let's define |
@gyuho sounds good I got this to work the newline seemed to cause the issue between body and the binding. Will issue PR. |
@hexfusion I got it to work, by adding comma after body line? |
Some Lease related URIs for the HTTP/JSON API appear to be incorrect in the generated Swagger API definitions at: https://github.com/coreos/etcd/blob/master/Documentation/dev-guide/apispec/swagger/rpc.swagger.json
Correct URIs:
Possibly incorrect URIs:
As per the API guide, I think these should not be under the "kv" service. Not sure if the problem is just with the Swagger JSON but also in the code.
The text was updated successfully, but these errors were encountered: