Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: deprecate grpc.ErrClientConnClosing #9304

Closed
gyuho opened this issue Feb 8, 2018 · 2 comments · Fixed by #10981
Closed

clientv3: deprecate grpc.ErrClientConnClosing #9304

gyuho opened this issue Feb 8, 2018 · 2 comments · Fixed by #10981

Comments

@gyuho
Copy link
Contributor

gyuho commented Feb 8, 2018

grpc.ErrClientConnClosing is being deprecated at grpc/grpc-go#1854.

https://github.com/coreos/etcd/blob/fe94f8f53af1c2ab684df713bf7e084ef3f1c675/clientv3/client.go#L550-L551

Just to not forget when we rewrite clientv3 balancer with new gRPC versions.

@gyuho gyuho added this to the v3.4.0 milestone Feb 8, 2018
@dfawley
Copy link

dfawley commented Feb 8, 2018

Note that by the grpc-go versioning policy, we cannot and will not remove this*, as it would break backward compatibility.

However, it's possible small behavior changes will be necessary that cause us to return other errors instead of ErrClientConnClosing in various circumstances, so you should not typically rely on any specific errors unless the godoc is explicit about what will be returned.

  • EDIT - until a MAJOR release (which may necessitate a new import path).

@gyuho
Copy link
Contributor Author

gyuho commented Feb 8, 2018

@dfawley Thanks for update! We will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants