Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: clean up random sleep time values #8781

Closed
gyuho opened this issue Oct 27, 2017 · 3 comments
Closed

tests: clean up random sleep time values #8781

gyuho opened this issue Oct 27, 2017 · 3 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Oct 27, 2017

#8762 (comment)

To help maintain the tests and keep flakiness to a minimum, should we establish a set of constants that we references from the integration tests instead? E.g instead of 3 here, maybe have a constant like maxLeaderChangeWait. Once we have a reasonable set of constants, then developers don't need to try to figure out what a good number of seconds is each time they write a test, and if we determine we need to increase the number to minimize test flakes based, we can change it in one place...

#8779 (comment)

as @jpbetz mentioned in other pr, we should define leader election timeout as a const somehere. and normal waiting timeout too. so this could be rewritten to electionWait + retryWait

Also #8757 (comment) and #8795.

/cc @jpbetz @xiang90

@hexfusion
Copy link
Contributor

If this is not been picked up I would like to give it a go.

@xiang90
Copy link
Contributor

xiang90 commented Dec 8, 2017

@hexfusion sure. thanks.

@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants