-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency github.com/golang.protobuf #7787
Comments
Is there a reason why https://github.com/deejross/mydis/blob/master/glide.yaml isn't pinning etcd, grpc, and grpc-gateway versions / revisions at all? I'm surprised anything works with the way it is now. |
I've been updating glide.yaml to pin versions and ran into this. I haven't committed it yet, but this is my entry in glide.yaml for etcd: - package: github.com/coreos/etcd
version: ^3.1.6 |
@deejross etcd v3.1.x uses grpc v1.0.x https://github.com/coreos/etcd/blob/release-3.1/glide.yaml#L86 |
@gyuho: after having a discussion with the grpc-gateway folks, I think I have better understanding of the underlying problem. I might end up falling back to using the same versions Etcd uses for grpc, grpc-gateway, and protobuf. The trick is ensuring the compiler plugins are also using the same versions. I still think the Semantic Versioning rules were violated in this case (by grpc-gateway) but I think I have a workaround. Etcd has, so far, been an excellent configuration database backend and adding additional functionality on top of it (which is what the Mydis project does) has ended up becoming the primary configuration backend for a project I'm working on, with MongoDB being used for non-configuration data. Etcd is an amazing project that has a decent sized code base, but updating some of its dependencies may not be a bad thing. |
I started getting this error in my builds which depends on Etcd, gRPC, and gRPC-Gateway:
After finally figuring out that Etcd uses a version of golang/protobuf from 2016, I forced Glide to update to a newer version and started seeing this warning:
Now that I've overcome this issue, I ran into another one where gRPC-Gateway's attempt to sync with gRPC-Go's version numbers introduced backwards-incompatible changes in a patch release, which is a big no-no in Semantic Versioning. I've already submitted feedback that they should stop doing that: grpc-ecosystem/grpc-gateway#365
The text was updated successfully, but these errors were encountered: