Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable grpc interceptors in serve Context like userHandlers are enabled #18896

Closed
nicolaslopezbravo opened this issue Nov 15, 2024 · 3 comments
Closed

Comments

@nicolaslopezbravo
Copy link

What would you like to be added?

embed's serve creates a new v3rpc grpc server but doesn't make use of the interceptor option. Could serve context have userInterceptors similar to userHandlers so the user can add & pass in interceptors to the grpc server?

Why is this needed?

Extends existing capability, allows for user to add all sorts of useful middleware, monitoring, auth, etc.

@nicolaslopezbravo
Copy link
Author

nicolaslopezbravo commented Nov 18, 2024

CC @ahrtr just want to check if this is reasonable, I can implement it if necessary. Is there any permissions required to create a pr?

@nicolaslopezbravo
Copy link
Author

Nevermind, this is the feature I was looking for #14066. Sorry I'm a bit new to etcd, are releases scheduled at any particular intervals? Looking to see when v3.6 will be released https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.6.md

@jmhbnz
Copy link
Member

jmhbnz commented Nov 20, 2024

Hey @nicolaslopezbravo thanks for your question - for etcd 3.6 we need to address the remaining items in this roadmap: https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/roadmap.md#v360

I'll close this now given the feature is ready and will be published in 3.6.

@jmhbnz jmhbnz closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants