Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable-grpc-gateway is not documented, but may be required #18890

Open
4 tasks done
robinchrist opened this issue Nov 14, 2024 · 3 comments
Open
4 tasks done

enable-grpc-gateway is not documented, but may be required #18890

robinchrist opened this issue Nov 14, 2024 · 3 comments

Comments

@robinchrist
Copy link

robinchrist commented Nov 14, 2024

Bug report criteria

What happened?

When running etcd via config file, the enable-grpc-gateway may be required (see #12093).

When running via CLI args, gRPC gateway is implicitly enabled. When running via config file, it is not.

What did you expect to happen?

Ideally, grpc gateway should always be enabled by default (to match the behaviour of config file to the behaviour of running via CLI options)

If this is not possible, the flag should be documented at least

How can we reproduce it (as minimally and precisely as possible)?

See #12093

Anything else we need to know?

No response

@moficodes
Copy link
Member

I can take a stab at it!

@moficodes
Copy link
Member

/assign

@TeoLefebvre
Copy link

Hello, is it done ? Because on my side it looks that grpc-gateway is now enabled by default even when etcd is launched using a config file and that the option enable-grpc-gateway is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants