Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLSA provenance to your releases #17873

Open
udf2457 opened this issue Apr 24, 2024 · 11 comments
Open

Add SLSA provenance to your releases #17873

udf2457 opened this issue Apr 24, 2024 · 11 comments
Assignees
Labels
area/security area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature

Comments

@udf2457
Copy link

udf2457 commented Apr 24, 2024

What would you like to be added?

Please add SLSA provenance to your releases.

It is easy to do on on Github:

https://github.com/slsa-framework/slsa-github-generator/blob/main/internal/builders/generic/README.md#provenance-for-goreleaser
https://goreleaser.com/blog/slsa-generation-for-your-artifacts/#slsa-github-generator

Background info:
https://docs.sigstore.dev/signing/overview/

Why is this needed?

Improving robustness against supply-chain attacks.

@udf2457 udf2457 changed the title Add SLSA attestation to your releases Add SLSA provenance to your releases Apr 24, 2024
@serathius
Copy link
Member

Contributions are welcomed

@udf2457
Copy link
Author

udf2457 commented Apr 24, 2024

Any further consideration given to moving to goreleaser @serathius as mentioned in #13980 ?

Adding provenance is a piece of cake with goreleaser.

I'm not sure why your present release.yml is why it is like it is ? Perhaps it predates goreleaser ? But tweaking your present release.yml to add provenance could be a time-consuming endeavour (at least for me, because I'm not familiar with the random shell scripts you are calling out to).

@serathius
Copy link
Member

@udf2457
Copy link
Author

udf2457 commented May 3, 2024

Github announced this yesterday, so will need to compare it to the process originally linked to see if it makes it more straightforward to implement.

@ArkaSaha30
Copy link
Contributor

Hello @serathius @udf2457 👋
I am interested to work on this issue

@udf2457
Copy link
Author

udf2457 commented May 7, 2024

Hi @ArkaSaha30

I am currently focused on some high-priority $work projects, so your offer of assistance is much appreciated @ArkaSaha30 😉

Hopefully when things quiet down a little at $work I will be able to return to this !

@serathius
Copy link
Member

Before jumping into coding, please start from reading the etcd release documentation to understand our current process and please propose what changes need to be made to provide SLSA provenance.

@jmhbnz jmhbnz added area/security priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 9, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Nov 13, 2024

cc @idunbarh

@idunbarh
Copy link

👋 folks! I was talking with @jmhbnz at the etcd project booth at kubecon. I'm happy to contribute signing the etcd release and container images in the build process. Since the release is done locally, it doesn't make sense to generate SLSA attestations.

I'm primarily interested in contributing SBOM generation for this project, I'll create a separate issue to track that.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 15, 2024

👋 folks! I was talking with @jmhbnz at the etcd project booth at kubecon. I'm happy to contribute signing the etcd release and container images in the build process. Since the release is done locally, it doesn't make sense to generate SLSA attestations.

I'm primarily interested in contributing SBOM generation for this project, I'll create a separate issue to track that.

Thanks @idunbarh was great to chat in person. Letting you know we are also in discussions with Kubernetes sig-release folks about finally moving away from locally produced releases making further use of Kubernetes project infrastructure and well defined build processes. As part of that it would be great to enable provenance. We'll update this issue as we make progress 🙏🏻

@idunbarh
Copy link

Sounds good. I'm happy to create a PR knowing that things could change in the future.

I'm also happy to support SBOM, SLSA attestations, and signing if the maintainers decide to move to new infra and if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security area/tooling priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature
Development

No branches or pull requests

6 participants