{markdown_you,govet_shadow,unparam,staticcheck,..}_pass fail in main branch

[fuweid]

Which github workflows are flaking?

Currently, there is no workflow to run {markdown_you,govet_shadow,unparam,staticcheck,..}_pass.

Which tests are flaking?

{markdown_you,govet_shadow,unparam,staticcheck,..}_pass fail in main branch

For instance,

PASSES="nakedret" TIMEOUT=1m CPU=4 ./scripts/test.sh 2>&1
go: downloading golang.org/x/crypto v0.7.0
Running with --race --cpu=4
Starting at: Wed Mar 22 18:02:21 HKT 2023

'nakedret' started at Wed Mar 22 18:02:21 HKT 2023
% (cd tools/mod && 'go' 'install' 'github.com/alexkohler/nakedret')
% (cd api && '/home/fuwei/go/bin/nakedret' './...')
% (cd tools/mod && 'go' 'install' 'github.com/alexkohler/nakedret')
% (cd pkg && '/home/fuwei/go/bin/nakedret' './...')
% (cd tools/mod && 'go' 'install' 'github.com/alexkohler/nakedret')
% (cd client/pkg && '/home/fuwei/go/bin/nakedret' './...')
stderr: transport/keepalive_listener.go:107: Accept naked returns on 8 line function
stderr: transport/listener.go:113: newKeepAliveListener naked returns on 11 line function
stderr: transport/listener.go:216: SelfCert naked returns on 138 line function
stderr: transport/listener.go:226: SelfCert naked returns on 138 line function
stderr: transport/listener.go:231: SelfCert naked returns on 138 line function
stderr: transport/listener.go:235: SelfCert naked returns on 138 line function
stderr: transport/listener.go:245: SelfCert naked returns on 138 line function
stderr: transport/listener.go:257: SelfCert naked returns on 138 line function
stderr: transport/listener.go:295: SelfCert naked returns on 138 line function
stderr: transport/listener.go:306: SelfCert naked returns on 138 line function
stderr: transport/listener.go:316: SelfCert naked returns on 138 line function
stderr: transport/listener.go:326: SelfCert naked returns on 138 line function
stderr: transport/listener.go:337: SelfCert naked returns on 138 line function

PASSES="ineffassign" TIMEOUT=1m CPU=4 ./scripts/test.sh 2>&1
Running with --race --cpu=4
Starting at: Wed Mar 22 18:03:29 HKT 2023

'ineffassign' started at Wed Mar 22 18:03:29 HKT 2023
% (cd tools/mod && 'go' 'install' 'github.com/gordonklaus/ineffassign')
stderr: go: downloading golang.org/x/tools v0.7.0
stderr: go: downloading golang.org/x/mod v0.9.0
% (cd api && '/home/fuwei/go/bin/ineffassign' '/home/fuwei/go/src/go.etcd.io/etcd/api/etcdserverpb/raft_internal_stringer.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/etcdserverpb/raft_internal_stringer_test.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/doc.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/error.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/md.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/metadatafields.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/error_test.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/version/version.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/version/version_test.go')
stderr: -: named files must all be in one directory; have /home/fuwei/go/src/go.etcd.io/etcd/api/etcdserverpb and /home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes
stderr: ineffassign: error during loading
FAIL: (code:1):
  % (cd api && '/home/fuwei/go/bin/ineffassign' '/home/fuwei/go/src/go.etcd.io/etcd/api/etcdserverpb/raft_internal_stringer.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/etcdserverpb/raft_internal_stringer_test.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/doc.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/error.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/md.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/metadatafields.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/v3rpc/rpctypes/error_test.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/version/version.go' '/home/fuwei/go/src/go.etcd.io/etcd/api/version/version_test.go')

FAIL: 'ineffassign_per_package ./...' checking failed (!=0 return code)
FAIL: 'ineffassign' failed at Wed Mar 22 18:03:31 HKT 2023

Github Action link

No response

Reason for failure (if possible)

It needs to update the lint rule or code.

REF: https://github.com/etcd-io/etcd/pull/15519/files

Anything else we need to know?

Work items:

• markdown_you - scripts: remove the markdown_you_pass #16709
• markdown_marker - *: enable markdown_marker checker #16708
• govet_shadow - *: fix govet-shadow lint #16608
• ineffassign - *: fix ineffassign lint #16605
• nakedret - *: fix nakedret lint #16601
• unconvert - *: cleanup unconvert_pass and remove revive tools #16714
• unparam - *: enable and fix unparam lint #16622

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[fuweid]

Will file pr to close it

[jmhbnz]

Hey @fuweid - It looks like you got the sub tasks all merged for this, are we good to close this now?

[fuweid]

Hi @jmhbnz , sorry I forgot to update the work items. I just updated the description of this issue. Please take a look. We still have 4 items to go.

[fuweid]

All the items have been closed. Cheer!

[ahrtr]

thx @fuweid

Great work!