etcd depends on two different versions of the same package - grpc-gateway

[dims]

If you see the bill-of-materials.json, you will see both "github.com/grpc-ecosystem/grpc-gateway/v2" and "github.com/grpc-ecosystem/grpc-gateway"
https://github.com/etcd-io/etcd/blob/main/bill-of-materials.json#L264-L280

Can we please switch to /v2 version as this is needed by the new otel libraries?

[dims@dims-m1-7728 22:12] ~/go/src/github.com/etcd-io/etcd ⟩ go mod graph | grep github.com/grpc-ecosystem/grpc-gateway/v2
go.etcd.io/etcd/v3 github.com/grpc-ecosystem/grpc-gateway/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] github.com/antihax/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] github.com/ghodss/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] github.com/google/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] github.com/rogpeppe/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] golang.org/x/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] google.golang.org/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] google.golang.org/[email protected]
github.com/grpc-ecosystem/grpc-gateway/[email protected] google.golang.org/[email protected]
go.etcd.io/etcd/server/[email protected] github.com/grpc-ecosystem/grpc-gateway/[email protected]
go.etcd.io/etcd/tests/[email protected] github.com/grpc-ecosystem/grpc-gateway/[email protected]
go.opentelemetry.io/proto/[email protected] github.com/grpc-ecosystem/grpc-gateway/[email protected]

The older one is references here:

[dims@dims-m1-7728 22:12] ~/go/src/github.com/etcd-io/etcd ⟩ go mod graph | grep github.com/grpc-ecosystem/grpc-gateway | grep -v v2
go.etcd.io/etcd/v3 github.com/grpc-ecosystem/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/antihax/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/ghodss/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/rogpeppe/[email protected]
github.com/grpc-ecosystem/[email protected] golang.org/x/[email protected]
github.com/grpc-ecosystem/[email protected] golang.org/x/[email protected]
github.com/grpc-ecosystem/[email protected] golang.org/x/[email protected]
github.com/grpc-ecosystem/[email protected] google.golang.org/[email protected]
github.com/grpc-ecosystem/[email protected] google.golang.org/[email protected]
go.etcd.io/etcd/api/[email protected] github.com/grpc-ecosystem/[email protected]
go.etcd.io/etcd/server/[email protected] github.com/grpc-ecosystem/[email protected]
go.etcd.io/etcd/tests/[email protected] github.com/grpc-ecosystem/[email protected]
go.opentelemetry.io/proto/[email protected] github.com/grpc-ecosystem/[email protected]

Would kindly request this to be cherry-picked on 3.5.x branch as well! (so we can then pick it up for kubernetes/kubernetes).

thanks!

[dims]

cc @ahrtr

[ahrtr]

Thanks @dims for raising this issue.

etcd is directly using grpc-gateway v1.16.0, but indirectly depends on grpc-gateway 2.7.0. It's exactly the same as Kubernetes. Have you upgraded or are you planning to upgrade to grpc-gateway /v2 for Kubernetes?

Anyway, let me check take care of this for etcd. Please clarify the plan on Kubernetes side.

[ahrtr]

It seems that Kubernetes just indirectly depends on grpc-gateway, including both 1.16.0 and 2.7.0.

[ahrtr]

Note: The grpc-gateway v1 is in maintenance mode, so we should migrate to v2. FYI. https://grpc-ecosystem.github.io/grpc-gateway/docs/development/grpc-gateway_v2_migration_guide/

[ahrtr]

I am working on #14463 right now. Please feel free to work on this one if you have extra bandwidth. cc @serathius @spzala @ptabor

If nobody work on this when I finish #14463 (hopefully this week or early next week), then I will work on this by then.

[dims]

It seems that Kubernetes just indirectly depends on grpc-gateway, including both 1.16.0 and 2.7.0.

yep, that's what i am trying to fix ultimately :)

[ahrtr]

Since nobody works on this, I will work on this starting from late next week.

[ahrtr]

We might need to resolve #14533 in the first step.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[liggitt]

We might need to resolve #14533 in the first step.

does #14533 block this specifically? I'm curious how

[liggitt]

getting etcd off of grpc-gateway v1 will be important to complete kubernetes/kubernetes#113366

[ahrtr]

I do not get time to dig into it, but most likely it's intertwined with #14533

#15145 might be a separate hot potato.

[ahrtr]

@fuweid do you have bandwidth and be interested in taking a deep dive into this issue and #14533?

[fuweid]

/assign

@ahrtr Sure!

[ahrtr]

Resolved in #16595

[ahrtr]

The change will be included in etcd 3.6.0. @dims

[dims]

thanks @ahrtr