Broken go.mod file (3.4): version tag not corresponding with package name

[bozaro]

Issue

I can't get add to project etcd client 3.4+ without tricks:

➜  go get go.etcd.io/[email protected]
go get go.etcd.io/[email protected]: go.etcd.io/[email protected]: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v

Workaround

Add module replace by commit hash instead of tag name:

➜  git rev-list -n 1 v3.4.9
54ba9589114fc3fa5cc36c313550b3c0c0938c91
➜  go mod edit -replace go.etcd.io/etcd=github.com/etcd-io/etcd@$(git rev-list -n 1 v3.4.9)
➜  cat go.mod 
module bozaro.ru/example

go 1.14

replace go.etcd.io/etcd => github.com/etcd-io/etcd v0.5.0-alpha.5.0.20200520232829-54ba9589114f

Correct solution (unfortunatelly it is breaking change)

1. Update package name in go.mod by adding v3 suffix:

➜  go mod edit -module go.etcd.io/etcd/v3 go.mod

2. Update package name in all *.go files:

➜  find . -type f -name '*.go' -exec sed -i -e 's,go.etcd.io/etcd,go.etcd.io/etcd/v3,g' {} \;

References

• Golang blog: https://blog.golang.org/v2-go-modules
• Example of working repository: https://github.com/olivere/elastic/blob/v7.0.17/go.mod

[ldelossa]

I also think "go getting" the latest commit hash pulls in the correct code without the need for the replace.

[ptabor]

I believe this got fixed in 3.5.x branch: #11820 .
I think changes of all imports paths are too big change for backporting to a patch release.

[ptabor]

Please see #12068 (comment) for summary of the current etcd go.mod situation.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[feldgendler]

@ptabor Hi! This is half a year old, and v3.5.0 is still not released. Can we hope for either a v3.5.0 release, or a fix on the v3.4.x branch?

[ptabor]

I plan to finalize #12652 (grpc-1.32 - that is code complete) and make experimental 3.5.0-alpha.0 release.
There is no readmap (unfortunately) for final 3.5.0 release.

[feldgendler]

@ptabor Thanks a lot for the update!