Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "etcdmain: fix ignoring of ETCD_CONFIG_FILE env variable" into 3.3 branch? #10878

Closed
kallisti5 opened this issue Jul 8, 2019 · 3 comments

Comments

@kallisti5
Copy link

kallisti5 commented Jul 8, 2019

In #10747 , passing ETCD_CONFIG_FILE as an environment variable doesn't work as expected.
A fix was accepted into master in ea70731 (with doc updates later accepted as well, #10762)

Can this be merged for inclusion into 3.3.14 ? (unless 3.4 is planned soon?)

This issue prevents easily deploying an etcd cluster in docker swarm with compose. (You can go - template out node replica numbers in environment vars, but not in command line variables)

Since this is a "can't even run" issue, it would be nice to get it in sooner than later. The risks are low as well since it is "just fixing existing code paths"

@jingyih
Copy link
Contributor

jingyih commented Jul 8, 2019

cc @gyuho who is the 3.3 release manager.

I think this is a bug fix and should be backported.

@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this as completed Apr 28, 2020
@EugenKon
Copy link

Very sad, that so important issues are automatically closed without care =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants