From 7c9ded2288b4b766342f1a856eb9cc1787500dc2 Mon Sep 17 00:00:00 2001 From: Chao Chen Date: Thu, 26 Oct 2023 11:12:07 -0700 Subject: [PATCH] tests/e2e: add comments that desired behavior after all the readyz/livez checks are implemented Signed-off-by: Chao Chen --- tests/e2e/http_health_check_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/e2e/http_health_check_test.go b/tests/e2e/http_health_check_test.go index 0e74a562b4e6..6d93b501d5aa 100644 --- a/tests/e2e/http_health_check_test.go +++ b/tests/e2e/http_health_check_test.go @@ -226,7 +226,7 @@ func TestHTTPLivezReadyzHandler(t *testing.T) { }, { url: "/readyz", - expectedStatusCode: http.StatusOK, + expectedStatusCode: http.StatusOK, // TODO expected behavior should be 503 or timeout after ReadIndex check is implemented. }, }, }, @@ -240,11 +240,11 @@ func TestHTTPLivezReadyzHandler(t *testing.T) { // ref. https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/etcd/local.go#L225-L226 // current liveness probe depends on the etcd /health check has a flaw that new /livez check should resolve. url: "/livez", - expectedStatusCode: http.StatusOK, + expectedStatusCode: http.StatusOK, // TODO expected behavior should be 503 or timeout after RaftLoopDeadLock check is implemented. }, { url: "/readyz", - expectedStatusCode: http.StatusOK, + expectedStatusCode: http.StatusOK, // TODO expected behavior should be 503 or timeout after ReadIndex check is implemented. }, }, },