474 etq visiteur personne non connectée je peux récupérer un catalogue de donnée au format csv #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Volubyl
force-pushed
the
474-etq-visiteur-personne-non-connectée-je-peux-récupérer-un-catalogue-de-donnée-au-format-csv
branch
from
09c2092 to
0adddca
Compare
…-peux-récupérer-un-catalogue-de-donnée-au-format-csv
|
@florimondmanca si tu passes par ici |
There was a problem hiding this comment.
Notre pair programming a donné un bon résultat !
J'ai remarqué encore qq améliorations possibles
J'ai testé en utilisant la doc d'API, le Cache-Control fait effet de ce côté là aussi puisqu'après le 1er appel, je ne vois plus de log d'accès côté API, c'est le navigateur qui répond avec son cache local. 👍
florimondmanca
force-pushed
the
474-etq-visiteur-personne-non-connectée-je-peux-récupérer-un-catalogue-de-donnée-au-format-csv
branch
from
201ae9e to
e3f3688
Compare
|
Notes En suite possible ("nice to have"), il y aurait le fait d'invalider le cache quand on ajoute, modifie ou supprime un jeu de données. Cela signifierait d'appeler quelque chose comme |
Volubyl
commented
Oct 11, 2022
…-peux-récupérer-un-catalogue-de-donnée-au-format-csv
|
@florimondmanca on merge ? |
|
Oui. |
florimondmanca
deleted the
474-etq-visiteur-personne-non-connectée-je-peux-récupérer-un-catalogue-de-donnée-au-format-csv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #437
Cette PR ajoute
Pour tester
Aller sur l'url <nom_de_domaine>/api/catalalogs/:siret_organisation/export.csv